Refactor Python and Orthanc Dockerfiles#583
Merged
jeremyestein merged 11 commits intomainfrom Jan 6, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 87.24% 87.24%
=======================================
Files 76 76
Lines 3380 3380
=======================================
Hits 2949 2949
Misses 431 431 ☔ View full report in Codecov by Sentry. |
p-j-smith
approved these changes
Dec 19, 2024
Contributor
p-j-smith
left a comment
There was a problem hiding this comment.
looking really nice - just a question around downloading the DICOM spec for Orthanc Anon
stefpiatek
approved these changes
Dec 19, 2024
Contributor
stefpiatek
left a comment
There was a problem hiding this comment.
Looks good, will leave it to you and Paul to work out the best way to have the python spec downloaded and cached
in orthanc-anon anyway)
p-j-smith
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #588 :
A cut down version of #400 , with just the Dockerfile de-duping. If we decide #400 is too risky to merge now, we can at least merge this one and do the rest of #400 later. The advantage is it enables further work on the Dockerfiles, such as switching to
uv.Type of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.squash and merge