11. Container With Most Water #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodchip
reviewed
Aug 3, 2025
| int right = heights.size() - 1; | ||
| int max_amount_water = -1; | ||
| while (left < right) { | ||
| int height = min(heights[left], heights[right]); |
There was a problem hiding this comment.
先に left または right を動かしてから、 max_amount_water を更新してもよいと思いました。ループの前に max_amount_water を、両端を壁にしたときの水の容量で初期化しておく必要はあります。
thonda28
reviewed
Aug 3, 2025
thonda28
left a comment
thonda28
left a comment
There was a problem hiding this comment.
2点気になったことをコメントしましたが、コードはとてもわかりやすかったです。
| int maxArea(vector<int>& heights) { | ||
| int left = 0; | ||
| int right = heights.size() - 1; | ||
| int max_amount_water = -1; |
There was a problem hiding this comment.
memo に書いてましたが、-1 での初期化は違和感がありました。0 がよいと思います
Comment on lines
+4
to
+6
| if (heights.empty()) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
この部分がなくても heights が empty のときには 0 を返すように思いました。（while 文を通らないので初期値の 0 をそのまま返す）
そのまま処理しても問題がない場合は特殊処理を追加せず、うまく動かないケースのみをエッジケースとして特殊処理で弾くのがよいのではと個人的には思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題へのリンク
https://leetcode.com/problems/container-with-most-water/description/
問題文(プレミアムの場合)
備考
次に解く問題の予告
Sum of Two Integers
フォルダ構成
LeetCodeの問題ごとにフォルダを作成します。
フォルダ内は、step1.cpp、step2.cpp、step3.cpp、brute_force.cppとmemo.mdとなります。
memo.md内に各ステップで感じたことを追記します。