15. 3Sum #74
Open
15. 3Sum #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 つの問題のソースコードが 1 つの PR に含まれているように見えます。 |
nodchip
reviewed
Jul 31, 2025
| while (left < right) { | ||
| int sum = nums[index] + nums[left] + nums[right]; | ||
| if (sum < 0) { | ||
| left++; |
There was a problem hiding this comment.
sum < 0 と sum > 0 の場合は continue し、 sum == 0 の場合のネストを下げたほうが読みやすいと思います。
| right--; | ||
| } else { | ||
| triplets.push_back({nums[index], nums[left], nums[right]}); | ||
| left++; |
There was a problem hiding this comment.
do while 文で回すと 1 行減ります。読みやすさはあまり変わらないかもしれません。
| } | ||
|
|
||
| private: | ||
| void FindTriplet(vector<int>& nums, int index, vector<vector<int>>& triplets) { |
There was a problem hiding this comment.
nums が非 const 参照だと、読み手にとって中で変更されるのだと思わせてしまうと思います。 nums は変更されないため、 const 参照で渡すことをおすすめします。
LeetCode が指定した関数宣言については、仕方ないと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題へのリンク
https://leetcode.com/problems/3sum/description/
問題文(プレミアムの場合)
備考
次に解く問題の予告
Container With Most Water
フォルダ構成
LeetCodeの問題ごとにフォルダを作成します。
フォルダ内は、step1.cpp、step2.cpp、step3.cpp、brute_force.cpp、sort.cppとmemo.mdとなります。
memo.md内に各ステップで感じたことを追記します。