209. Minimum Size Subarray Sum #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
Mar 5, 2025
| } | ||
|
|
||
| private: | ||
| static constexpr int NOANSWER = numeric_limits<int>::max(); |
There was a problem hiding this comment.
個人的には、これ定数で置かないほうが、上から読んでいって自然に理解できると思いますが、わりと趣味の範囲かなとは思います。
TORUS0818
reviewed
Jul 8, 2025
|
|
||
| ## 他の方の解法 | ||
| leetcodeの解答例でsum += nums[r++];というふうにインクリメントしながらsumに追加する方法があった。 | ||
| 1行に２つの処理を纏めるより分けた方が好み。 |
|
|
||
| Pythonのmath.infは型がfloat。言語が変わるとこの辺りの仕様は理解しておかないとバグに繋がりそう。 | ||
| 右側をループで回す方法で解いたが、左側を回す方法もあり。 | ||
| 余談、cumulative sumを略してcum sumというの知らなかった。。。 |
There was a problem hiding this comment.
numpyにもcumsumメソッドがあります。
https://numpy.org/doc/2.2/reference/generated/numpy.cumsum.html
ただ、そんなに一般的ではない、という反応を見た記憶もあります。
nodchip
reviewed
Jul 12, 2025
| int minSubArrayLen(int target, vector<int>& nums) { | ||
| vector<int> cumulative_sum(nums.size() + 1); | ||
| cumulative_sum[0] = 0; | ||
| for (int i = 0; i < nums.size(); i++) { |
There was a problem hiding this comment.
std::partial_sum() も使えると思います。
vector<int> cumulative_sum(1);
std::partial_sum(nums.begin(), nums.end(), std::back_inserter(cumulative_sum));読みやすいかは微妙なところだと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題へのリンク
https://leetcode.com/problems/minimum-size-subarray-sum/description/
問題文(プレミアムの場合)
備考
次に解く問題の予告
Permutations
フォルダ構成
LeetCodeの問題ごとにフォルダを作成します。
フォルダ内は、step1.cpp、step2.cpp、step2_2.cpp、step3.cpp、cumulative_sum.cppとmemo.mdとなります。
memo.md内に各ステップで感じたことを追記します。