Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/fortifier-macros/src/validate/enum.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use proc_macro2::TokenStream;
use quote::{format_ident, quote};
use syn::{DataEnum, DeriveInput, Ident, Result, Variant, Visibility};
use syn::{DataEnum, DeriveInput, Generics, Ident, Result, Variant, Visibility};

use crate::{
validate::{
Expand Down Expand Up @@ -30,6 +30,7 @@ impl<'a> ValidateEnum<'a> {
for variant in &data.variants {
result.variants.push(ValidateEnumVariant::parse(
&input.vis,
&input.generics,
result.ident,
result.error_ident.clone(),
variant,
Expand Down Expand Up @@ -109,6 +110,7 @@ pub struct ValidateEnumVariant<'a> {
impl<'a> ValidateEnumVariant<'a> {
pub fn parse(
visibility: &'a Visibility,
generics: &'a Generics,
enum_ident: &'a Ident,
enum_error_ident: Ident,
variant: &'a Variant,
Expand All @@ -119,6 +121,7 @@ impl<'a> ValidateEnumVariant<'a> {
ident: &variant.ident,
fields: ValidateFields::parse(
visibility,
generics,
format_ident!("{}{}", enum_ident, variant.ident),
&variant.fields,
)?,
Expand Down
6 changes: 3 additions & 3 deletions packages/fortifier-macros/src/validate/field.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use convert_case::{Case, Casing};
use proc_macro2::{Literal, TokenStream};
use quote::{ToTokens, format_ident, quote};
use syn::{Error, Field, Ident, Result, Visibility};
use syn::{Error, Field, Generics, Ident, Result, Visibility};

use crate::{
validate::{
Expand Down Expand Up @@ -46,6 +46,7 @@ pub struct ValidateField<'a> {
impl<'a> ValidateField<'a> {
pub fn parse(
visibility: &'a Visibility,
generics: &'a Generics,
type_prefix: &Ident,
ident: LiteralOrIdent,
field: &Field,
Expand Down Expand Up @@ -128,10 +129,9 @@ impl<'a> ValidateField<'a> {
}
}

// TODO: Use enum/struct generics to determine if a generic field type supports nested validation.
if !skip_nested
&& result.validations.is_empty()
&& let Some(nested_type) = should_validate_type(&field.ty)
&& let Some(nested_type) = should_validate_type(generics, &field.ty)
{
if let KnownOrUnknown::Known(nested_type) = nested_type {
result.validations.push(Box::new(Nested::new(nested_type)));
Expand Down
37 changes: 27 additions & 10 deletions packages/fortifier-macros/src/validate/fields.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use std::iter::empty;

use proc_macro2::{Literal, TokenStream};
use quote::quote;
use syn::{Fields, FieldsNamed, FieldsUnnamed, Ident, Result, Visibility};
use syn::{Fields, FieldsNamed, FieldsUnnamed, Generics, Ident, Result, Visibility};

use crate::{
validate::{
Expand All @@ -22,14 +22,19 @@ pub enum ValidateFields<'a> {
}

impl<'a> ValidateFields<'a> {
pub fn parse(visibility: &'a Visibility, ident: Ident, fields: &'a Fields) -> Result<Self> {
pub fn parse(
visibility: &'a Visibility,
generics: &'a Generics,
ident: Ident,
fields: &'a Fields,
) -> Result<Self> {
Ok(match fields {
Fields::Named(fields) => {
Self::Named(ValidateNamedFields::parse(visibility, ident, fields)?)
}
Fields::Unnamed(fields) => {
Self::Unnamed(ValidateUnnamedFields::parse(visibility, ident, fields)?)
}
Fields::Named(fields) => Self::Named(ValidateNamedFields::parse(
visibility, generics, ident, fields,
)?),
Fields::Unnamed(fields) => Self::Unnamed(ValidateUnnamedFields::parse(
visibility, generics, ident, fields,
)?),
Fields::Unit => Self::Unit(ValidateUnitFields::parse(visibility, ident)?),
})
}
Expand Down Expand Up @@ -94,7 +99,12 @@ pub struct ValidateNamedFields<'a> {
}

impl<'a> ValidateNamedFields<'a> {
fn parse(visibility: &'a Visibility, ident: Ident, fields: &'a FieldsNamed) -> Result<Self> {
fn parse(
visibility: &'a Visibility,
generics: &'a Generics,
ident: Ident,
fields: &'a FieldsNamed,
) -> Result<Self> {
let error_ident = format_error_ident(&ident);

let mut result = Self {
Expand All @@ -111,6 +121,7 @@ impl<'a> ValidateNamedFields<'a> {

result.fields.push(ValidateField::parse(
visibility,
generics,
&result.ident,
LiteralOrIdent::Ident(field_ident.clone()),
field,
Expand Down Expand Up @@ -173,7 +184,12 @@ pub struct ValidateUnnamedFields<'a> {
}

impl<'a> ValidateUnnamedFields<'a> {
fn parse(visibility: &'a Visibility, ident: Ident, fields: &'a FieldsUnnamed) -> Result<Self> {
fn parse(
visibility: &'a Visibility,
generics: &'a Generics,
ident: Ident,
fields: &'a FieldsUnnamed,
) -> Result<Self> {
let error_ident = format_error_ident(&ident);

let mut result = Self {
Expand All @@ -186,6 +202,7 @@ impl<'a> ValidateUnnamedFields<'a> {
for (index, field) in fields.unnamed.iter().enumerate() {
result.fields.push(ValidateField::parse(
visibility,
generics,
&result.ident,
LiteralOrIdent::Literal(Literal::usize_unsuffixed(index)),
field,
Expand Down
7 changes: 6 additions & 1 deletion packages/fortifier-macros/src/validate/struct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ pub struct ValidateStruct<'a> {
impl<'a> ValidateStruct<'a> {
pub fn parse(input: &'a DeriveInput, data: &'a DataStruct) -> Result<Self> {
Ok(ValidateStruct {
fields: ValidateFields::parse(&input.vis, input.ident.clone(), &data.fields)?,
fields: ValidateFields::parse(
&input.vis,
&input.generics,
input.ident.clone(),
&data.fields,
)?,
})
}

Expand Down
Loading