Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Jan 28, 2026

Summary

Adds explicit guidance to the read_command_output tool description telling models to omit the search parameter entirely when not filtering, rather than passing null or empty string.

This prevents models from mistakenly passing the literal string "null" as a search pattern, which causes the tool to search for lines containing the text "null" instead of returning all content.

Changes

  • Updated the search parameter description in the tool's overall description to include: "Omit this parameter entirely if you don't need to filter - do not pass null or empty string."
  • Updated the SEARCH_DESCRIPTION constant with the same guidance

Context

Investigation found that models sometimes pass "search": "null" when they intend "no search filter". The tool was designed with strict: false specifically so models could omit optional parameters. This documentation update teaches models the correct behavior.


Important

Clarifies search parameter usage in read_command_output.ts to omit it when not filtering.

  • Documentation:
    • Updated search parameter description in read_command_output.ts to instruct omitting it if not filtering.
    • Updated SEARCH_DESCRIPTION constant with the same guidance.

This description was created by Ellipsis for c2f6d00. You can customize this summary. It will automatically update as commits are pushed.

… not filtering

Add explicit guidance to the search parameter description telling models to
omit the parameter entirely if not searching, rather than passing null or
empty string. This prevents models from mistakenly passing literal "null"
string as a search pattern.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Documentation Improvements or additions to documentation labels Jan 28, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 28, 2026

Oroocle Clock   See task on Roo Cloud

Review complete. No issues flagged.

  • No issues to address

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 28, 2026
@hannesrudolph hannesrudolph merged commit d7fa963 into main Jan 28, 2026
20 checks passed
@hannesrudolph hannesrudolph deleted the fix/read-command-output-search-docs branch January 28, 2026 20:30
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 28, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants