Workaround clashes of constants with newer icx #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses compatibility issues with newer Intel C++ Compiler (icx) by preventing constant name clashes through conditional compilation. The version is bumped from 1.15.1 to 1.15.2.
- Moved constant definitions behind preprocessor guards to avoid conflicts with newer icx compiler
- Converted
floatbitsfrom a regular inline function to a constexpr function for constant initialization - Updated project version to 1.15.2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rkcommon/math/math.ih | Added preprocessor guards to separate ISPC and C++ constant definitions; made floatbits constexpr for compile-time evaluation |
| CMakeLists.txt | Incremented project version from 1.15.1 to 1.15.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.