BaseRTMPClientHandler.onChunkSize:Don't update writeChunkSize#54
Open
rawler wants to merge 1 commit intoRed5:masterfrom
Open
BaseRTMPClientHandler.onChunkSize:Don't update writeChunkSize#54rawler wants to merge 1 commit intoRed5:masterfrom
rawler wants to merge 1 commit intoRed5:masterfrom
Conversation
The RTMP specification states clearly, that "The maximum chunk size is maintained independently for each direction". That means that our peer updating its chunkSize, does not affect our outgoing chunkSize. A change in writeChunkSize must be accompanied by a SetChunkSize message of our own, otherwise our peer have no reliable way to know what chunksize to use for each message. https://rtmp.veriskope.com/docs/spec/?#541set-chunk-size-1
Author
|
Some context; I've been struggling to get red5 working with another RTMP implementation. After digging around, it seems like the problem is that if |
Author
|
@mondain Any chance to have a look at this? |
Member
|
@rawler thanks for the patch, I'll do a review / test and see about adding it as soon as I can. Also be aware that the on-going development of Red5 client is moved to the red5-server repo; the server project has been modularized instead of staying in separate repos. |
acassiovilasboas
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RTMP specification states clearly, that "The maximum chunk size is
maintained independently for each direction". That means that our peer
updating its chunkSize, does not affect our outgoing chunkSize. A change
in writeChunkSize must be accompanied by a SetChunkSize message of our own,
otherwise our peer have no reliable way to know what chunksize to use for
each message.
https://rtmp.veriskope.com/docs/spec/?#541set-chunk-size-1