delete unused testing files, use reusable workflow for CI#625
Closed
JacksonBurns wants to merge 6 commits intomainfrom
Closed
delete unused testing files, use reusable workflow for CI#625JacksonBurns wants to merge 6 commits intomainfrom
JacksonBurns wants to merge 6 commits intomainfrom
Conversation
Contributor
Author
|
Currently failing because the action on RMG-Py uses checkout on RMG-Py and tries to build the environment file over here without having it. Action should clone RMG-Py if it is running on RMG-database (without disrupting the current setup), and expose the same rmg_Database_branch equivalent for rmg-py. |
Contributor
Author
|
This run will fail, and then it should be retriggered after RMG-Py#2494 is merged (ReactionMechanismGenerator/RMG-Py#2494) |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://github.blog/2022-02-10-using-reusable-workflows-github-actions/ this change will use the regression testing action in place on RMG-Py to run all the regression tests here as well. Waiting on ReactionMechanismGenerator/RMG-Py#2472 to be merged before restarting the tests here to make sure they work.