Open
Conversation
davidfarinajr
force-pushed
the
cathub
branch
3 times, most recently
from
7108a94 to
e90a3b4
Compare
mazeau
reviewed
Sep 14, 2021
| ) | ||
|
|
||
| entry( | ||
| index = 80, |
Contributor
There was a problem hiding this comment.
C3H6X2 and C3H5X2 are bidentate species and I don't think this should match this family
mazeau
reviewed
Sep 14, 2021
| ) | ||
|
|
||
| entry( | ||
| index = 82, |
Contributor
There was a problem hiding this comment.
C3H5X2-2 and C3H4X2 are bidentate species
mazeau
reviewed
Sep 14, 2021
| ) | ||
|
|
||
| entry( | ||
| index = 83, |
Contributor
There was a problem hiding this comment.
C3H5X2-3 and C3H4X2-2 are bidentate species
mazeau
force-pushed
the
cathub
branch
2 times, most recently
from
142e387 to
89ea1c6
Compare
only with Eas, As are None
these are reactions which currently dont match any of our families
The duplicate cathub reactions were converted to MultiArrh. However, we do not want to add these rates together, so I converted them to SurfaceArrhenius and selected the more recent calculation (SchumannSelectivity2018)
Since we now consider metal attrs when descending the tree, these need to be removed from thermo group entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to add kinetic data from cat hub (https://www.catalysis-hub.org)