Correct the rates should be expressed in MultiArrhenius form within FFCM mechanism#187
Merged
Correct the rates should be expressed in MultiArrhenius form within FFCM mechanism#187
Conversation
…FCM mechanism There are rates of total 7 reactions in FFCM should be shown in FFCM form, but the previous version has only one with that form. The rest 6 only has single Arrhenius form corresponding to the first Arrhenius in FFCM. Now they are corrected and should be able to capture both high and low temperature.
alongd
approved these changes
May 4, 2017
| ), | ||
| Arrhenius( | ||
| A = (5.017e+12, 'cm^3/(mol*s)'), | ||
| n = 0.664, |
Member
There was a problem hiding this comment.
@jimchu10 , I think n should be -0.664 here.
Could you check and correct?
Contributor
Author
There was a problem hiding this comment.
Thank you. I made the change in the updated pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are rates of total 7 reactions in FFCM should be shown in MultiArrhenius form, but the previous version has only one with that form.
The rest 6 only has single Arrhenius form corresponding to the first Arrhenius in FFCM.
Now they are corrected and should be able to capture both high and low temperature.