Conversation
…end archetype This also reduces the total number of groups and makes it more flexible to add more groups.
…tion *4/*5 depending on which version was a label reserved for backbones that now should not be in any end groups after commit
-too specific backbone groups changed -some backbone groups renamed
-Removed extraneous labels -Removed all _D and _T backbone forms that restricted the doublebond_intra end group -Suitably generalized the other backbone forms so that they matched the end groups
the tree is now broken up from one tree for R1=R2-O-R4 into trees for R1, R2 and R4 respectively (with an additional one level backbone tree), the rules have been sorted into the new tree structure
This attribute states the most inward atom labels that overlaps between the end groups and backbones. It is useful for helping to separate the backbone from the end group for unit-testing.
nyee
force-pushed
the
unimol_kineticsPart2
branch
2 times, most recently
from
e06eb55 to
cfd05a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unimolecular Group formatting changes and testing.
A new test requires that end group labels are consistent throughout each end group tree, that the backbone has all labels present in the end groups and labels indicating the shortest path between end groups, and that each end group subgraph in each entry in the backbone tree is the top level of the corresponding end group tree.
Specifically exempts Diels_alder_addition family from these requirements because of its strange structure (to be fixed later)
Groups were adapted to meet these requirements and pass all database tests. Part2 includes the problematic families that need more thorough review of the RMG-tests.