Skip to content

Added the C2H4 +O surface as a kinetic library#1216

Merged
mliu49 merged 1 commit intomasterfrom
c2h4o
Oct 18, 2017
Merged

Added the C2H4 +O surface as a kinetic library#1216
mliu49 merged 1 commit intomasterfrom
c2h4o

Conversation

@alongd
Copy link
Member

@alongd alongd commented Oct 17, 2017

Added the C2H4+O_Klipp2017 library to documentation.
This is a twin PR of ReactionMechanismGenerator/RMG-database#219

@codecov
Copy link

codecov bot commented Oct 17, 2017 •
edited
Loading

Codecov Report

Merging #1216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1216   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files         171      171           
  Lines       27935    27935           
  Branches     5454     5454           
=======================================
  Hits        12223    12223           
  Misses      14886    14886           
  Partials      826      826

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2617829...18e481c. Read the comment docs.

@alongd alongd requested a review from amarkpayne October 18, 2017 02:23
amarkpayne
amarkpayne reviewed Oct 18, 2017
View reviewed changes
Copy link
Member

@amarkpayne amarkpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one comment, but otherwise it looks good. The documentation built from this was formatted properly. Let me know what you think about the caption, and then this should be ready to merge.

documentation/source/users/rmg/database/kinetics.rst Outdated
+---------------------------------------+------------------------------------------------------------------------------------------+
|BurkeH2O2inN2 |Comprehensive H2/O2 kinetic model in N2 atmosphere |
+---------------------------------------+------------------------------------------------------------------------------------------+
|C2H4+O_Klipp2017 |C2H4 + O (including intersystem crossing), probably important for all C/H/O combustion |
Copy link
Member

@amarkpayne amarkpayne Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library is just the intersystem crossing reactions right? If so the description should be the following:

C2H4 + O intersystem crossing reactions, probably important for all C/H/O

Copy link
Member Author

@alongd alongd Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alongd alongd added the Status: Accepted This PR is approved and ready to be merged label Oct 18, 2017
@amarkpayne
Copy link
Member

amarkpayne commented Oct 18, 2017

@mliu49, can you merge this pull request for me?

@amarkpayne amarkpayne mentioned this pull request Oct 18, 2017
Merged
@mliu49 mliu49 merged commit 2470e49 into master Oct 18, 2017
@mliu49 mliu49 deleted the c2h4o branch October 18, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarkpayne amarkpayne amarkpayne approved these changes

Assignees

No one assigned

Labels

Status: Accepted This PR is approved and ready to be merged Twin RMG-database PR Type: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alongd @amarkpayne @mliu49