escape one frollsd tests for valgrind #7548
Conversation
| exact_NaN = isTRUE(capabilities()["long.double"]) && identical(as.integer(.Machine$longdouble.digits), 64L) | ||
| if (!exact_NaN) { | ||
| cat("\n**** Skipping 7 NaN/NA algo='exact' tests because .Machine$longdouble.digits==", .Machine$longdouble.digits, " (!=64); e.g. under valgrind\n\n", sep="") | ||
| cat("\n**** Skipping 8 NaN/NA algo='exact' tests because .Machine$longdouble.digits==", .Machine$longdouble.digits, " (!=64); e.g. under valgrind\n\n", sep="") |
There was a problem hiding this comment.
Maybe we could do something like nskip for foreign messages to avoid incrementing this manually
data.table/R/test.data.table.R
Line 336 in 7e9907f
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7548 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 87 87
Lines 16733 16733
=======================================
Hits 16561 16561
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| y = c(1e8+2.980232e-8, 1e8, 1e8, 1e8) # CLAMP0 test | ||
| test(6001.731, frollvar(y, 3)[4L], 0) | ||
| test(6001.732, frollsd(y, 3)[4L], 0) | ||
| if (exact_NaN) test(6001.732, frollsd(y, 3)[4L], 0) |
There was a problem hiding this comment.
the other cases are all using algo='exact', so this would be the first case being skipped with algo='fast'
There was a problem hiding this comment.
it's also v. interesting that frollvar(y, 3)[4L], which per glancing the implementation only differs by applying sqrt(), does not have this numerical difference issue
2 participants
Closes #7546
Haven't tested, but looking at
and
I think it should do