fix: Don't open the toolbox when clicking beneath the categories #9535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
reviewed
Dec 22, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Might it be possible to add a test to verify the behavior?
Contributor
Author
|
Added a test as well. |
rachel-fenichel
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9198
Proposed Changes
This PR fixes a bug where clicking in the toolbox below the list of categories would cause the flyout to open with the first toolbox category selected. That behavior is preserved when the toolbox is focused via the keyboard. If the flyout is open, clicking in the toolbox below the list of categories will still dismiss it, as will clicking the selected category.