remove the need for WALLET_JSON env var#7
Open
MichaelBuhler wants to merge 1 commit intoRandAOLabs:mainfrom
Open
remove the need for WALLET_JSON env var#7MichaelBuhler wants to merge 1 commit intoRandAOLabs:mainfrom
MichaelBuhler wants to merge 1 commit intoRandAOLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
ao-process-clientsusesPATH_TO_WALLETenv var, so bothPATH_TO_WALLETandWALLET_JSONare needed.This actually presents a problem that the contents of the env var may be different from the contents of the wallet file.
We can just read the contents of the file instead of using the
WALLET_JSONenv var, simplifying thedocker-compose.ymland the provider's.envfile.WALLET_JSON.PATH_TO_WALLET.PATH_TO_WALLETis not set.IMPORTANT:
This PR requires
randao/orchestratorto be build and published to Docker Hub, then another commit to update the version tag in thedocker-compose.yml.