Skip to content

remove the need for WALLET_JSON env var#7

Open
MichaelBuhler wants to merge 1 commit intoRandAOLabs:mainfrom
MarshalAO:MichaelBuhler/remove-wallet-json-env-var
Open

remove the need for WALLET_JSON env var#7
MichaelBuhler wants to merge 1 commit intoRandAOLabs:mainfrom
MarshalAO:MichaelBuhler/remove-wallet-json-env-var

Conversation

@MichaelBuhler
Copy link

Currently ao-process-clients uses PATH_TO_WALLET env var, so both PATH_TO_WALLET and WALLET_JSON are needed.

This actually presents a problem that the contents of the env var may be different from the contents of the wallet file.

We can just read the contents of the file instead of using the WALLET_JSON env var, simplifying the docker-compose.yml and the provider's .env file.

  • Remove WALLET_JSON.
  • Read the wallet from the file at PATH_TO_WALLET.
  • Orchestrator will fail to boot if PATH_TO_WALLET is not set.

IMPORTANT:

This PR requires randao/orchestrator to be build and published to Docker Hub, then another commit to update the version tag in the docker-compose.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant