[build] - Support for removing OPENMP_STANDALONE_BUILD logic upstream #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estewart08
force-pushed
the
remove-openmp-standalone-logic-support
branch
3 times, most recently
from
0102b38 to
115ef84
Compare
estewart08
force-pushed
the
remove-openmp-standalone-logic-support
branch
from
115ef84 to
eb4f000
Compare
estewart08
requested review from
carlobertolli and
zGoldthorpe
as code owners
carlobertolli
approved these changes
Dec 1, 2025
estewart08
force-pushed
the
remove-openmp-standalone-logic-support
branch
from
eb4f000 to
8c65b24
Compare
Support for openmp and offload debug/perf/asan libraries has moved to build_llvm_runtimes_standalone.sh. This script invokes the cmake in llvm-project/runtimes instead of the openmp or offload directories. Upstream will eventually remove OPENMP_STANDALONE_BUILD. - LLVM_BINARY_DIR introduced to notify the runtimes standalone build where clang is.
estewart08
force-pushed
the
remove-openmp-standalone-logic-support
branch
from
8c65b24 to
f47fa45
Compare
Contributor
Author
|
testing with ROCm/llvm-project#1223 |
First we will remove OPENMP_STANDALONE_BUILD from openmp upstream and then move on to offload removal. Once that happens we can add offload to the build_llvm_runtimes_standalone.sh list.
estewart08
force-pushed
the
remove-openmp-standalone-logic-support
branch
from
eeb9f6e to
4609d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for openmp and offload debug/perf/asan libraries has moved to build_llvm_runtimes_standalone.sh. This script invokes the cmake in llvm-project/runtimes instead of the openmp or offload directories. Upstream will eventually remove OPENMP_STANDALONE_BUILD.
This will be dependent on a LLVM patch.