Skip to content

Reverse rules for Enzyme #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kshyatt wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Reverse rules for Enzyme #86

kshyatt wants to merge 3 commits into from

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Oct 22, 2025

No description provided.

@kshyatt kshyatt requested review from Jutho and lkdvos October 22, 2025 19:25
@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 1.34228% with 147 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl 0.67% 147 Missing ⚠️
Files with missing lines Coverage Δ
src/common/safemethods.jl 100.00% <100.00%> (ø)
...ixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl 0.67% <0.67%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt kshyatt force-pushed the ksh/enzyme branch 2 times, most recently from 4408849 to ec8354b Compare October 24, 2025 12:26
kshyatt
kshyatt commented Oct 27, 2025
View reviewed changes
kshyatt
kshyatt commented Oct 27, 2025
View reviewed changes
@kshyatt kshyatt force-pushed the ksh/enzyme branch 4 times, most recently from 7478c90 to 9091c56 Compare November 13, 2025 13:55
@kshyatt kshyatt force-pushed the ksh/enzyme branch 2 times, most recently from 6ab2c5a to 7e76c77 Compare December 11, 2025 16:18
@kshyatt kshyatt mentioned this pull request Dec 11, 2025
Open
@kshyatt
Copy link
Member Author

kshyatt commented Dec 16, 2025

OK, I think this is ready for review!

Jutho
Jutho reviewed Dec 16, 2025
View reviewed changes
@kshyatt
Copy link
Member Author

kshyatt commented Dec 17, 2025

1.12 failures really seem unrelated/Enzyme internal, not sure what to do about it other than disable the Enzyme tests on 1.12 until it becomes more stable there.

@kshyatt kshyatt force-pushed the ksh/enzyme branch 4 times, most recently from f478efa to 830c82c Compare December 19, 2025 15:18
@kshyatt
Copy link
Member Author

kshyatt commented Dec 19, 2025

OK, for unknown and likely extremely brain melting reasons, adding a repr(a) call specifically for ComplexF32 fixes all the problems with NaN we were seeing. It's upsetting and I'm not sure why, maybe inlining? Either way, while I investigate that, this should help unblock CI a little

@kshyatt
Copy link
Member Author

kshyatt commented Dec 19, 2025

Culprit seems to be inlining for ComplexF32 specifically, which is weird, and makes me unhappy, but at least we don't have to print to an unused string now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jutho Jutho Jutho left review comments

@lkdvos lkdvos Awaiting requested review from lkdvos

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kshyatt @Jutho @lkdvos