Add test for binary STLs with 'solid' header and fix STLDocument#27
Open
MHebes wants to merge 2 commits intoQuantumConcepts:masterfrom
Open
Add test for binary STLs with 'solid' header and fix STLDocument#27MHebes wants to merge 2 commits intoQuantumConcepts:masterfrom
MHebes wants to merge 2 commits intoQuantumConcepts:masterfrom
Conversation
Member
JoshMcCullough
left a comment
There was a problem hiding this comment.
Thank you, looks good. Couple tweaks...
Author
|
@JoshMcCullough Responding to all your comments at once: It appears that It is my understanding that |
Author
|
Happy to adjust whitespace or formatting as you wish, though. I had a lot of trouble getting the pre-push git hook working on windows + git bash. |
JoshMcCullough
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
@JoshMcCullough ping