Skip to content

feat(notification-channel-modal): add email in the creation flow#2377

Merged
RemiBonnet merged 3 commits intostagingfrom
fix/alert-email
Feb 13, 2026
Merged

feat(notification-channel-modal): add email in the creation flow#2377
RemiBonnet merged 3 commits intostagingfrom
fix/alert-email

Conversation

@pggb25
Copy link
Collaborator

@pggb25 pggb25 commented Feb 13, 2026

Summary

https://qovery.slack.com/archives/C090XR4CA69/p1770972792925219

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@qovery-github-app
Copy link

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview e68a6997-01bc-4a01-adcd-e763ade8d2ae test-prod-clone-pipeline-clone-test
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.96%. Comparing base (f7fe6ef) to head (8664811).
⚠️ Report is 4 commits behind head on staging.

Files with missing lines Patch % Lines
...ation-channel-modal/notification-channel-modal.tsx 73.68% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2377      +/-   ##
===========================================
+ Coverage    46.93%   48.96%   +2.03%     
===========================================
  Files         1225      408     -817     
  Lines        22720     9715   -13005     
  Branches      6726     2974    -3752     
===========================================
- Hits         10663     4757    -5906     
+ Misses       10045     4045    -6000     
+ Partials      2012      913    -1099     
Flag Coverage Δ
unittests 48.96% <73.68%> (+2.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Introduced a new `renderNotificationChannelModal` function to enhance test rendering with `act`.
- Updated tests to utilize the new rendering function for better async handling.
- Removed the 'Webhook' option from the channel type selection to streamline available options.
- Adjusted payload handling to use the selected receiver type consistently across create and edit modes.
@RemiBonnet RemiBonnet changed the title add link to the doc for the email alert notification feat(notification-channel-modal): add email in the creation flow Feb 13, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review February 13, 2026 10:29
…tests

- Added tests to verify default and custom display name behavior when switching from Slack to Email.
- Introduced a constant for default channel names to streamline name assignment based on selected channel type.
- Updated the channel type selection logic to maintain custom display names when changing types.
@RemiBonnet RemiBonnet self-requested a review February 13, 2026 10:41
@RemiBonnet RemiBonnet merged commit a564a00 into staging Feb 13, 2026
24 of 26 checks passed
@RemiBonnet RemiBonnet deleted the fix/alert-email branch February 13, 2026 12:16
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.286.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants