feat(notification-channel-modal): add email in the creation flow#2377
feat(notification-channel-modal): add email in the creation flow#2377RemiBonnet merged 3 commits intostagingfrom
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2377 +/- ##
===========================================
+ Coverage 46.93% 48.96% +2.03%
===========================================
Files 1225 408 -817
Lines 22720 9715 -13005
Branches 6726 2974 -3752
===========================================
- Hits 10663 4757 -5906
+ Misses 10045 4045 -6000
+ Partials 2012 913 -1099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Introduced a new `renderNotificationChannelModal` function to enhance test rendering with `act`. - Updated tests to utilize the new rendering function for better async handling. - Removed the 'Webhook' option from the channel type selection to streamline available options. - Adjusted payload handling to use the selected receiver type consistently across create and edit modes.
…tests - Added tests to verify default and custom display name behavior when switching from Slack to Email. - Introduced a constant for default channel names to streamline name assignment based on selected channel type. - Updated the channel type selection logic to maintain custom display names when changing types.
|
🎉 This PR is included in version 1.286.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
https://qovery.slack.com/archives/C090XR4CA69/p1770972792925219
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release