Skip to content

updated time evolution circuit to match hamiltonian. Re-ran.#4627

Open
christopherporter1 wants to merge 3 commits intomainfrom
cp/kryham2
Open

updated time evolution circuit to match hamiltonian. Re-ran.#4627
christopherporter1 wants to merge 3 commits intomainfrom
cp/kryham2

Conversation

@christopherporter1
Copy link
Collaborator

Fixes #4589

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

"# backend = service.backend(\"ibm_torino\")"
"# backend = service.least_busy(operational=True, simulator=False)\n",
"# backend = service.backend(\"ibm_torino\")\n",
"service = QiskitRuntimeService(\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know CRNs aren't sensitive the way API keys are, but is it definitely ok to include one in this code?

"metadata": {},
"source": [
"Let us specify the maximum Krylov dimension we wish to use, though we will check for convergence at smaller dimensions. We also specify the number of Trotter steps to use in the time evolution. For the sake of this lesson, we will choose a small Krylov dimension of just 5. This is quite limited in the context of realistic applications, but it is sufficient for this example. We will explore methods in later lessons that allow us to scale and project our Hamiltonians onto larger subspaces."
"Let us specify the maximum Krylov dimension we wish to use, though we will check for convergence at smaller dimensions. We also specify the number of Trotter steps to use in the time evolution. For the sake of this lesson, we will choose a small Krylov dimension of just 4. This is quite limited in the context of realistic applications, but it is sufficient for this example. We will explore methods in later lessons that allow us to scale and project our Hamiltonians onto larger subspaces."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the word "just".
IBM Style says the following: 'Omit "just" if the omission does not change the sentence meaning. Do not use "just" to mean "only"; use "only" instead.' (I presume this makes auto-translation easier.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Discrepancy between Hamiltonian and Time evolution circuit

3 participants