Organise plate_reading package
#803
Conversation
it's a mess :)
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the plate_reading package by creating vendor-specific subdirectories (molecular_devices, bmg_labtech, agilent) and moving backend implementations into these subdirectories. The changes maintain backward compatibility by creating deprecation shim files at the original locations.
Key Changes
- Created vendor-specific subdirectories for plate reader backends
- Moved existing backend files to appropriate vendor directories
- Added deprecation warnings for old import paths
- Updated internal imports to reflect new package structure
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pylabrobot/plate_reading/molecular_devices/backend.py | New file containing moved MolecularDevices backend code |
| pylabrobot/plate_reading/molecular_devices_backend.py | Converted to deprecation shim with re-exports |
| pylabrobot/plate_reading/bmg_labtech/clario_star_backend.py | New file containing moved CLARIOstar backend code |
| pylabrobot/plate_reading/clario_star_backend.py | Converted to deprecation shim |
| pylabrobot/plate_reading/agilent/*.py | Updated imports to reflect new structure |
| pylabrobot/plate_reading/init.py | Updated to import from new vendor subdirectories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from pylabrobot.io.serial import Serial | ||
| from pylabrobot.plate_reading.backend import PlateReaderBackend | ||
| from pylabrobot.resources.plate import Plate | ||
| from .molecular_devices.backend import ( # noqa: F401s |
There was a problem hiding this comment.
Extra 's' character in 'F401s' - should be 'F401'.
| from .molecular_devices.backend import ( # noqa: F401s | |
| from .molecular_devices.backend import ( # noqa: F401 |
| "pylabrobot.plate_reading.biotek_backend is deprecated and will be removed in a future release. " | ||
| "Please use pylabrobot.plate_reading.agilent.biotek_backend instead.", |
There was a problem hiding this comment.
The deprecation warning message refers to 'biotek_backend' but this file is 'biotek_cytation_backend'. The message should indicate the correct deprecated module name.
| "pylabrobot.plate_reading.biotek_backend is deprecated and will be removed in a future release. " | |
| "Please use pylabrobot.plate_reading.agilent.biotek_backend instead.", | |
| "pylabrobot.plate_reading.biotek_cytation_backend is deprecated and will be removed in a future release. " | |
| "Please use pylabrobot.plate_reading.agilent.biotek_cytation_backend instead.", |
2 participants
No description provided.