Skip to content

Add mode to Codec, display C func in err #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WyattBlue merged 1 commit into from
Feb 2, 2025
Merged

Add mode to Codec, display C func in err #1746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions av/codec/codec.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ class Codec:
def is_encoder(self) -> bool: ...
@property
def is_decoder(self) -> bool: ...
@property
def mode(self) -> Literal["r", "w"]: ...
descriptor: Descriptor
@property
def name(self) -> str: ...
Expand Down
6 changes: 5 additions & 1 deletion av/codec/codec.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ cdef class Codec:
raise RuntimeError("%s is both encoder and decoder.")

def __repr__(self):
mode = "w" if self.is_encoder else "r"
mode = self.mode
return f"<av.{self.__class__.__name__} {self.name} {mode=}>"

def create(self, kind = None):
Expand All @@ -130,6 +130,10 @@ cdef class Codec:
from .context import CodecContext
return CodecContext.create(self)

@property
def mode(self):
return "w" if self.is_encoder else "r"

@property
def is_decoder(self):
return not self.is_encoder
Expand Down
8 changes: 4 additions & 4 deletions av/codec/context.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ cdef class CodecContext:
cdef int res
with nogil:
res = lib.avcodec_send_frame(self.ptr, frame.ptr if frame is not None else NULL)
err_check(res)
err_check(res, "avcodec_send_frame()")

packet = self._recv_packet()
while packet:
Expand All @@ -337,7 +337,7 @@ cdef class CodecContext:
cdef int res
with nogil:
res = lib.avcodec_send_packet(self.ptr, packet.ptr if packet is not None else NULL)
err_check(res)
err_check(res, "avcodec_send_packet()")

out = []
while True:
Expand Down Expand Up @@ -365,7 +365,7 @@ cdef class CodecContext:

if res == -EAGAIN or res == lib.AVERROR_EOF:
return
err_check(res)
err_check(res, "avcodec_receive_frame()")

frame = self._transfer_hwframe(frame)

Expand All @@ -384,7 +384,7 @@ cdef class CodecContext:
res = lib.avcodec_receive_packet(self.ptr, packet.ptr)
if res == -EAGAIN or res == lib.AVERROR_EOF:
return
err_check(res)
err_check(res, "avcodec_receive_packet()")

if not res:
return packet
Expand Down
Loading