Skip to content

Modify the percentage display for Tracker docker implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JINGJINGTANG wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify the percentage display for Tracker docker implementation #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/Cake/Console/Helper/ProgressShellHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function increment($num = 1) {
*
* @return void
*/
public function draw() {
public function draw($logged_percentage = 0) {
$numberLen = strlen(' 100%');
$complete = round($this->_progress / $this->_total, 2);
$barLen = ($this->_width - $numberLen) * ($this->_progress / $this->_total);
Expand All @@ -115,8 +115,11 @@ public function draw() {
if ($pad > 0) {
$bar .= str_repeat(' ', $pad);
}
$percent = ($complete * 100) . '%';
$bar .= str_pad($percent, $numberLen, ' ', STR_PAD_LEFT);
$this->_consoleOutput->overwrite($bar, 0);
$percent = ($complete * 100);
$bar .= str_pad($percent . '%', $numberLen, ' ', STR_PAD_LEFT);
if ($percent % 10 === 0 && $percent !== $logged_percentage) {
Copy link

@seanrabey seanrabey Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this check for @JINGJINGTANG ?
$percent !== $logged_percentage

Copy link
Collaborator Author

@JINGJINGTANG JINGJINGTANG Oct 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make sure we are only logging the same progress (percentage) once to the log file. Since we are logging the progress to a log file, we can't have it overwritten the previous log. Thus, we are logging 0%, 10%, 20%...etc

Copy link
Collaborator Author

@JINGJINGTANG JINGJINGTANG Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mcap parse, we would have this inside the for loop: $logged_percentage = $progress->draw($logged_percentage);

CakeLog::write('debug', $bar);
}
return $percent;
}
}