Docker optimize 2022 07 24 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
You will need to fix the Typescript code to pull from the environment variables defined in your local docker-compose.override.yml. THIS IS A BREAKING CHANGE |
Contributor
|
is this still an active pull request, or is it depricated? |
Contributor
Author
|
This works currently so long as the code base can pull environment variables from Linux envvars rather than a file. I can make it compatible by having it dump the variables into an internal file instead if we must but that seems hacky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated some of the workflow for Docker-compose and the Dockerfile. You'll be able to run
`