[DRAFT] Refacto / ABC classes #319
Draft
+1,004
−574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some ugly shenanigan a while back and it started to go out of hands: I must purify it by fire before it's too late.
Basically, I tended to instantiate base classes in specialized classes classmethods before converting them to the specialized classes.
It was some hot messy stuff, so I'm currently making all base classes pure ABC, and using template methods to create the specified classes in classmethods.
Currently, I've cleaned the base and audio-related classes, I still have to adapt the spectro-related classes and write a bunch of docstrings/additionnal tests.