Open
Conversation
12 tasks
ioannisj
commented
Jan 29, 2026
ioannisj
commented
Jan 29, 2026
marandaneto
reviewed
Jan 30, 2026
marandaneto
reviewed
Jan 30, 2026
marandaneto
reviewed
Jan 30, 2026
| @@ -1,5 +1,9 @@ | |||
| ## Next | |||
|
|
|||
| - feat: add manual session recording control APIs ([#256](https://github.com/PostHog/posthog-flutter/pull/256)) | |||
Member
There was a problem hiding this comment.
do those API work even if config.sessionReplay is disabled or both ways?
Collaborator
Author
There was a problem hiding this comment.
That's what we did for the other sdks I believe. So if local config is false, people can start a recording later on manually.
If remote config/flags is false, then no-op
Trying to validate these with some local testing
marandaneto
reviewed
Feb 4, 2026
|
|
||
| @override | ||
| Future<void> startSessionRecording({bool resumeCurrent = true}) async { | ||
| if (!isSupportedPlatform()) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!isSupportedPlatform()) { | |
| if (!isSupportedPlatform() || macOS) { |
all those methods should bail if its a macOS app since replay isnt supported, theres no need to call method channels if we know its not gonna work
the code above is just pseudocode
marandaneto
approved these changes
Feb 4, 2026
Member
marandaneto
left a comment
marandaneto
left a comment
There was a problem hiding this comment.
left 2 comments otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #124
Docs PR: PostHog/posthog.com#14487
💚 How did you test it?
Manual testing:
📝 Checklist