Fix issue with Distance text accessing invalid memory#5
Open
netpoetica wants to merge 1 commit intoPolyMarsDev:masterfrom
Open
Fix issue with Distance text accessing invalid memory#5netpoetica wants to merge 1 commit intoPolyMarsDev:masterfrom
netpoetica wants to merge 1 commit intoPolyMarsDev:masterfrom
Conversation
Fix score functions returning local variables that become inaccessible Remove unused variables triggering compiler warnings Add .gitignore to keep emscripten-generated files out Add emscripten compile to Makefile
Author
|
Oh and FWIW, this is just speculation, but I suspect the reason this issue only became pronounced in the browser is because of the way Emscripten uses heap/stack memory in the WASM world. I suspect in C++ executable land, this memory doesn't get garbage collected and you just had a memory leak, whereas in WASM, this unreferenced memory was getting garbage collected and pointers were becoming nullptr. |
|
Thanks? This also fixes issues on ARM processors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PolyMarsDev this fixes the issue you describe in your video (which I was able to recreate on my local). It wasn't actually any issue with SDL_TTF lib, but with the fact that you were returning a ptr to your local variable which was allocated on the stack and not on the heap. Of course it was very strange that high score worked fine but distance didn't, but such is the way with memory in C/C++.
I also removed some stuff that triggered compiler warnings! Thanks for putting this example together :) I agree with people that the controls are borderline impossible (jumping while still pushing with your cursor without killing your guy is rough), but I still would like to see you finish this game someday! Cheers and thanks for the video!
Fix score functions returning local variables that become inaccessible
Remove unused variables triggering compiler warnings
Add .gitignore to keep emscripten-generated files out
Add emscripten compile to Makefile