Add better rotation management options #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and applying last rotation state
JoseMoreville
previously requested changes
Oct 26, 2025
Member
|
|
TheMoonThatRises
dismissed
JoseMoreville’s stale review
Review request completed.
| identifier: .keymappingOptionsMenu, | ||
| options: .displayInline, | ||
| children: arrowKeyChildrenCommands) | ||
| let rotationTitles = [ |
Member
There was a problem hiding this comment.
If there are all of these options, it might be better to either remove rotations menus from Keymapping entirely or have it under a new group dedicated for screen rotations.
Author
There was a problem hiding this comment.
So is it fine if I remove the rotation options from Keymapping and make a new menu item called Rotation next to the Keymapping one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to keep pressing the display rotation button I wanted to add a way to both change the default orientation an application launches with and instead of a button to cycle through orientations have a list from which you can pick a specific orientation.
PlayCover/PlayCover#2011