-
Notifications
You must be signed in to change notification settings - Fork 83
Fix: app freeze or crash when click close button #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fca8afa to
fa3b5de
Compare
|
PR is ready for review, but I can't add reviewer myself. @TheMoonThatRises @JoseMoreville |
|
Now I try disable line_length check for apple document url, please review now~ @TheMoonThatRises @XuYicong |
|
I'm not sure that this should be commented out, as the developer documentation states that it may be called to terminate applications already in the background. I think more investigation into this would be necessary. |
@TheMoonThatRises I understand, you can feel free to test these IPA files and investigate the cause of the freeze or crash: [IPA link1]: Install IPA and open it(maybe need disable keymapping), wait few seconds then click red close button in window, app will freeze and not responding now. No freezing status when using [IPA link2]: Install IPA and open it(maybe need disable keymapping), wait few seconds then click red close button in window, "App quit unexpectedly" crashing popup will show after few second. No crashing popup when using |
@TheMoonThatRises Hi~ do you have any new ideas for this problem? |
Some apps will freeze or crash when click close button if we send willTerminateNotification. The developer documentation says this is a "may be called method", so it can be safely skipped.
https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623111-applicationwillterminate
Related PR: #136