Skip to content

Conversation

@juanan150
Copy link

No description provided.

Copy link

@hyfi06 hyfi06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

challenge.py Outdated
]

def homeless(worker):
worker['homeless'] = True if worker['organization'] == '' else False
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worker['organization'] == '' ya es un booleano

worker['homeless'] = worker['organization'] == ''

challenge.py Outdated

def run():
def older_than_30(person):
person['old'] = True if person['age'] >30 else False
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

person['age'] >30 ya es booleano

person['old'] = person['age'] >30

},
]

def homeless(worker):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aquí pasa pasa un diccionario por referencia, por lo que estás modificando DATA directamente. tienes que crear un nuevo diccionario y luego modificarlo.

new_worker = dict(worker)

return worker

def run():
def older_than_30(person):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recuerda que los diccionarios pasan por referencia. Tienes que crear uno nuevo para no modificar el original.

all_Platzi_workers = list(filter(lambda x: x['organization']=='Platzi',DATA))# Using filter, generate a list with all the Platzi workers
adults = list(filter(lambda x: x['age']>18,DATA))# Using filter, generate a list with all people over 18 years old
workers = list(map(homeless, DATA)) # Using map, generate a new list of people with a key 'homeless' with True or False values, if 'organization' have something or not
old_people = list(map(older_than_30, DATA)) # Using map, generate a new list of people with a key 'old' with True or False values, if 'age' is greater than 30 or not
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vas a notar que al imprimir old_people tienes también la información de homeless, por que se modificó DATA en la línea anterior.

Comment on lines +84 to +86
all_python_devs = list(filter(lambda x: x['language']=='python',DATA)) # Using filter, generate a list with all the python devs
all_Platzi_workers = list(filter(lambda x: x['organization']=='Platzi',DATA))# Using filter, generate a list with all the Platzi workers
adults = list(filter(lambda x: x['age']>18,DATA))# Using filter, generate a list with all people over 18 years old
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien!

@juanan150
Copy link
Author

Some comments

Ya hice los cambios, muchas gracias! 👍

Copy link

@hyfi06 hyfi06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants