Date-fns #1
Open
Date-fns #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyfi06
suggested changes
Apr 24, 2020
| const spanish = require('date-fns/locale/es'); | ||
|
|
||
| // today | ||
| const today = new Date(2020, 0, 1); |
There was a problem hiding this comment.
La fecha la estás fijando, esta debe de ser la que llega como parámetro de la función
Comment on lines
+15
to
+17
| const lastYear = sub(today, {years:1}); | ||
| const lastTwoYear = sub(today, {years:2}); | ||
| const lastThreeYear = sub(today, {years:3}); |
There was a problem hiding this comment.
Cuando repites código similar es señal que debes implementar una función o una clase
Comment on lines
+20
to
+22
| const lastMonth = sub(today, {months:1}); | ||
| const lastTwoMonth = sub(today, {months:2}); | ||
| const lastThreeMonth = sub(today, {months:3}); |
There was a problem hiding this comment.
Cuando repites código similar es señal que debes implementar una función o una clase
| endAt: format(endOfMonth(lastThreeMonth), 'yyyy/MM/dd') | ||
| }, | ||
|
|
||
| ]; |
There was a problem hiding this comment.
Cuando repites código similar es señal que debes implementar una función o una clase
Comment on lines
+50
to
+81
| { | ||
| label: format(lastYear, 'yyyy'), | ||
| startAt: format(startOfYear(lastYear), 'yyyy/MM/dd'), | ||
| endAt: format(endOfYear(lastYear), 'yyyy/MM/dd') | ||
| }, | ||
| { | ||
| label: format(lastTwoYear, 'yyyy'), | ||
| startAt: format(startOfYear(lastTwoYear), 'yyyy/MM/dd'), | ||
| endAt: format(endOfYear(lastTwoYear), 'yyyy/MM/dd') | ||
| }, | ||
| { | ||
| label: format(lastThreeYear, 'yyyy'), | ||
| startAt: format(startOfYear(lastThreeYear), 'yyyy/MM/dd'), | ||
| endAt: format(endOfYear(lastThreeYear), 'yyyy/MM/dd') | ||
| }, | ||
|
|
||
| // Filters per months | ||
| { | ||
| label: format(lastMonth, 'MMMM', {locale: spanish}), | ||
| startAt: format(startOfMonth(lastMonth), 'yyyy/MM/dd'), | ||
| endAt: format(endOfMonth(lastMonth), 'yyyy/MM/dd') | ||
| }, | ||
| { | ||
| label: format(lastTwoMonth, 'MMMM', {locale: spanish}), | ||
| startAt: format(startOfMonth(lastTwoMonth), 'yyyy/MM/dd'), | ||
| endAt: format(endOfMonth(lastTwoMonth), 'yyyy/MM/dd') | ||
| }, | ||
| { | ||
| label: format(lastThreeMonth, 'MMMM', {locale: spanish}), | ||
| startAt: format(startOfMonth(lastThreeMonth), 'yyyy/MM/dd'), | ||
| endAt: format(endOfMonth(lastThreeMonth), 'yyyy/MM/dd') | ||
| }, |
There was a problem hiding this comment.
Estos datos no se actualizan con el parámetro date, porque ya los fijaste en la linea 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.