feat(all): initial commit for managedSchema #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* Managed schema is a `recordSpace` where the schema is directly handled by the record-store. This allow to offer a dedicated grpc service that you can use to shim something, or offer another type of dev experience. The first Managed schema is the KV, which offers a Key/Value experience. It has his own grpc service that will be easier to implement. Others may follow.
StevenLeRoux
reviewed
Dec 6, 2020
docs/managed-schema.md
Outdated
|
|
||
| Record-Store is great to handle customers defined schema, but sometimes you may need to store something simple. | ||
|
|
||
| We are now providing dedicated `recordSpace` where the schema is directly handled by the Record-Store, lowering the difficulty to use the Record-Store. Under the hood, you will still open a `recordSpace`, but you will not be able to manipulate the schema. |
Collaborator
There was a problem hiding this comment.
Remove temporality (now). Would be better adopting a ligher style (we are providing => A recordSpace is a keyspace directly managed by... )
docs/managed-schema.md
Outdated
|
|
||
| ## Managed KeyValue | ||
|
|
||
| You want to use a simple key/value? We got you covered! We even offer a simplified gRPC service: |
| return getKeySpacePath(tenant, recordSpace, "unmanaged", "data"); | ||
| } | ||
|
|
||
| private static KeySpacePath getKeySpacePath(String tenant, String env, String recordSpaceType, String subDirectory) { |
Collaborator
There was a problem hiding this comment.
Don't you prefer to use a constant enum or boolean instead of a string to characterize managed/unmanaged?
Owner
Author
|
Resolved most of your comments @StevenLeRoux, a lot of files modified as I added a formatter with gradle. TODO: add a service to manage managedSchemas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Managed schema is a
recordSpacewhere the schema is directly handledby the record-store. This allow to offer a dedicated grpc service that
you can use to shim something, or offer another type of dev experience.
The first Managed schema is the KV, which offers a Key/Value experience.
It has his own grpc service that will be easier to implement. Others may
follow.