Allow option to initialise robot in any starting state#24
Closed
justagist wants to merge 1 commit intoPickNikRobotics:mainfrom
Closed
Allow option to initialise robot in any starting state#24justagist wants to merge 1 commit intoPickNikRobotics:mainfrom
justagist wants to merge 1 commit intoPickNikRobotics:mainfrom
Conversation
…bot starting state
|
This is what I need, thanks for your contribution @justagist. |
Author
|
Hi @JafarAbdi, can you review this please? |
Contributor
Should we use the initial_value from command_interface then? Maybe a better option is to completely remove https://github.com/PickNikRobotics/topic_based_ros2_control/blob/main/src/topic_based_system.cpp#L80-L98 and set both state/command interfaces to nan Do you mind sharing an example I can test? Thanks! |
Contributor
|
#28 should fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the plugin initialising joint commands using values from the
initial_valueparameter ofstate_interfacein theros2_controltag for each joint. This means the robot has to always start at the same configuration, which can be a problem in some cases.This PR introduces option to initialise the robot at any joint state, by initialising the commands with the first joint state value received via
joint_states_topic(if available while controller is loading).Introduces the
<param name="use_initial_states_as_initial_commands">true</param>tag to the plugin (defaults to false).