-
Notifications
You must be signed in to change notification settings - Fork 1
🩹 [Patch]: Remove output access hints from logs #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Try again |
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
|
@copilot Add a local action that we use in a test to see that the generated "output" suggestion is as expected. Find a way to automatically test that the output is correct. |
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
…demonstration code Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
I've added comprehensive automated testing for the output suggestions: Created:
What the tests verify:
The tests will run automatically on every PR and catch any regressions. Commit: 78b146b Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
… output help text generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes confusing output access hints from action logs. The hints showed how to access outputs using a specific pattern (${{ fromJson(steps.$env:GITHUB_ACTION.outputs.result).<outputName> }}), but this pattern varies depending on whether the action is used directly or nested within another composite action.
Changes:
- Removed output access hint text and decorative fence from
scripts/outputs.ps1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removes the output access hint text from the action logs to avoid confusion when the action is used directly or nested in another composite action. The output grouping and output content display remain unchanged.
Changes
scripts/outputs.ps1Rationale
The access pattern differs for direct vs nested usage, so printed hints can be misleading. Removing the hint avoids confusion while still showing the output values.