Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 18, 2025

Removes the output access hint text from the action logs to avoid confusion when the action is used directly or nested in another composite action. The output grouping and output content display remain unchanged.

Changes

  • Remove access-hint printing in scripts/outputs.ps1
  • Simplify composite output test by removing access-pattern demo and help-text validation

Rationale

The access pattern differs for direct vs nested usage, so printed hints can be misleading. Removing the hint avoids confusion while still showing the output values.

@MariusStorhaug
Copy link
Member

Try again

Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Copilot AI changed the title [WIP] 🩹 [Patch]: Improve help text on output when this action is used inside another composite action 🩹 [Patch]: Improve help text on output when this action is used inside another composite action Jun 20, 2025
@MariusStorhaug
Copy link
Member

@copilot Add a local action that we use in a test to see that the generated "output" suggestion is as expected. Find a way to automatically test that the output is correct.

Copilot AI and others added 4 commits January 16, 2026 22:38
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
…demonstration code

Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 16, 2026

@copilot Add a local action that we use in a test to see that the generated "output" suggestion is as expected. Find a way to automatically test that the output is correct.

I've added comprehensive automated testing for the output suggestions:

Created:

  1. Local composite action (.github/actions/test-composite/) that internally uses GitHub-Script
  2. Test job ActionTestCompositeOutputs in TestWorkflow.yml that validates both direct and nested usage scenarios
  3. Validation script (tests/validate-output-help-text.ps1) that programmatically tests the help text format

What the tests verify:

  • ✅ Direct usage shows correct step ID: ${{ fromJson(steps.direct-test.outputs.result).DirectOutput }}
  • ✅ Nested usage provides helpful placeholder: ${{ fromJson(steps.<your-step-id>.outputs.result).TestOutput1 }}
  • ✅ Fallback scenario without step ID works correctly
  • ✅ Both access patterns retrieve values successfully
  • ✅ Help text format matches expected regex patterns

The tests will run automatically on every PR and catch any regressions. Commit: 78b146b

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.powershellgallery.com
    • Triggering command: /usr/bin/pwsh pwsh -Command Install-PSResource -Name PSScriptAnalyzer -TrustRepository -Scope CurrentUser (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: Improve help text on output when this action is used inside another composite action 🩹 [Patch]: Remove output access hints from logs Jan 17, 2026
@MariusStorhaug MariusStorhaug marked this pull request as ready for review January 17, 2026 00:32
Copilot AI review requested due to automatic review settings January 17, 2026 00:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes confusing output access hints from action logs. The hints showed how to access outputs using a specific pattern (${{ fromJson(steps.$env:GITHUB_ACTION.outputs.result).<outputName> }}), but this pattern varies depending on whether the action is used directly or nested within another composite action.

Changes:

  • Removed output access hint text and decorative fence from scripts/outputs.ps1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MariusStorhaug MariusStorhaug merged commit 2010983 into main Jan 17, 2026
81 checks passed
@MariusStorhaug MariusStorhaug deleted the copilot/fix-54 branch January 17, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🩹 [Patch]: Remove output access hints from logs

2 participants