Skip to content

Elasticsearch implementation for Beneficiary Search #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vanitha1822 merged 4 commits into from
Dec 18, 2025
Merged

Elasticsearch implementation for Beneficiary Search #324

vanitha1822 merged 4 commits into from
Dec 18, 2025

Conversation

@vanitha1822
Copy link
Contributor

@vanitha1822 vanitha1822 commented Dec 16, 2025

📋 Description

JIRA ID:

AMM-1951

✅ Type of Change

  • ✨ New feature (non-breaking change which adds functionality)

@vanitha1822 vanitha1822 self-assigned this Dec 16, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nd/vs/AMM-1951-new

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vanitha1822 vanitha1822 requested a review from drtechie December 16, 2025 16:38
drtechie
drtechie reviewed Dec 17, 2025
View reviewed changes
src/main/java/com/iemr/common/service/beneficiary/IdentityBeneficiaryServiceImpl.java
.append("?query=").append(URLEncoder.encode(query, StandardCharsets.UTF_8));

if (userId != null) {
url.append("&userId=").append(userId);
Copy link
Member

@drtechie drtechie Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this userId come from? Is this the logged in user? Is this parameter going to create IDOR vulnerability?

Copy link
Contributor Author

@vanitha1822 vanitha1822 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Userid taken from token in the controller.

@vanitha1822 vanitha1822 requested a review from drtechie December 18, 2025 03:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 18, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vanitha1822 vanitha1822 merged commit 50c5952 into release-3.6.1 Dec 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtechie drtechie drtechie approved these changes

Assignees

@vanitha1822 vanitha1822

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vanitha1822 @drtechie