Add discrete noise distributions #654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweindl
force-pushed
the
discrete_noise_distr
branch
2 times, most recently
from
a3fe413 to
8c9f5aa
Compare
2 tasks
dweindl
force-pushed
the
discrete_noise_distr
branch
from
8c9f5aa to
ee15fcf
Compare
Adds Poisson, binomial, and negative binomial distributions to the list of noise distributions.
dweindl
force-pushed
the
discrete_noise_distr
branch
from
ee15fcf to
e94480b
Compare
4 tasks
sebapersson
approved these changes
Dec 3, 2025
Contributor
sebapersson
left a comment
sebapersson
left a comment
There was a problem hiding this comment.
Thanks for adding. Just a few minor comments.
|
|
||
| The measured value in the same units/scale as the model output. | ||
| If the corresponding ``noiseDistribution`` specifies a discrete distribution, | ||
| this value must be integral. |
Contributor
There was a problem hiding this comment.
Suggested change
| this value must be integral. | |
| this value must be an integer. |
| the current specification assumes independence, i.e. the full distribution is | ||
|
|
||
| .. math:: | ||
| \pi(D|Y,\Sigma) = \prod_i\pi(m_i|y_i,\sigma_i) |
Contributor
There was a problem hiding this comment.
As we have single-parameter distributions (e.g., Poison) that does not include a noise parameter, using a more general formula like: \pi(D|\theta) would maybe work better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Poisson, binomial, and negative binomial distributions to the list of noise distributions.
Closes #653.