-
Notifications
You must be signed in to change notification settings - Fork 6
add NamespacedIdentifier to Core API
#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
isn't the name a bit too long? maybe |
860c5d0 to
503cada
Compare
503cada to
6bebdc9
Compare
|
I updated the PR with more convenience methods for creating, validating, and parsing identifiers. I placed all of these in a separate class. For validation, I went with Just like in 1.13+, identifiers are validated upon creation, and an exception is thrown if validation fails. I decided to do this validation in the factory methods rather than in the constructor of the identifier itself, because I think it may be useful to be able to construct invalid identifiers when parsing them from a legacy source. |
|
Not sure what we're gonna do with the name yet. A bunch of discussion took place on Discord though. |
|
I'm of the opinion that names should tell you what isn't identical, in this case, very little of course, but using a synonym just for the sake of it being different doesn't help at all on that front. Something like |
|
I did not make |
|
oh one thing - it doesn't add the interface with interface injection yet, I'm saving that for later after some build script changes to make use of the fabric.mod.json generation task |
|
Maybe we could add a |
add `NamespacedIdentifier` to Core API
Essentially equivalent to Minecraft's
Identifier, it'll be very useful for future APIs, and also for the Networking rewrite I'm working on.I chose a different name to avoid the name conflict with the Vanilla class.