Create networking-common library for code that is largely version-agnostic
#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I also plan to do something similar for other libraries like Resource Loading and Lifecycle Events, wherever it makes sense. |
Member
Author
|
gonna close this in favor of merging #48 directly, as the split ended up working out a little differently as described here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Networking API has over a dozen modules, some with very small version ranges. This leads to quite a bit of code duplication for stuff that does depend on MC code but is largely version agnostic.
This PR introduces a Networking Common API, a new library designed to have just a few modules with MC dependent code that is largely version agnostic. So far, this removes about 1400 loc.
I plan to move more code into these modules, but that will likely lead to API code changes so I'll save it for a separate PR.