Added Serde feature and optionnal dependency#37
Draft
VirgileHenry wants to merge 2 commits intoOptimisticPeach:masterfrom
Draft
Added Serde feature and optionnal dependency#37VirgileHenry wants to merge 2 commits intoOptimisticPeach:masterfrom
VirgileHenry wants to merge 2 commits intoOptimisticPeach:masterfrom
Conversation
Author
|
After further investigation, I've found that the For this change to be sound, more work need to be done. Can all the usize be replaces to fixed size variants, such as u32 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to be able to serialize and deserialize
Subdivided<T, S>, so I forked the crate and addedserdeas an optional feature.Since others may have similar needs, and this has no impacts on anyone not using this feature, I told myself that it would be nice to merge this into the main crate!
Of course, if you think this is not a good idea or have arguments against it, feel free to reject this request.
Cheers,