Skip to content

Conversation

@Ndpnt
Copy link
Contributor

@Ndpnt Ndpnt commented Jan 14, 2026

  • Add release-decision job to ensure to trigger release only for commit that comes from a merged PR
  • Skip release workflow when commits on main are made by @OTA-Release-Bot
  • Add concurrency group to prevent simultaneous releases
  • Pin third-party actions to full commit SHA to prevent supply chain attacks
  • Simplify job dependencies to direct needs only, DRY

@Ndpnt Ndpnt requested a review from clementbiron January 14, 2026 14:45
@Ndpnt
Copy link
Contributor Author

Ndpnt commented Jan 14, 2026

You can see a skipped workflow because of commit done by OTABot here https://github.com/Ndpnt/engine/actions/runs/20997765168/job/60359032927

And a release here https://github.com/Ndpnt/engine/actions/runs/20997602539 (it fails but just because on my fork I did not have the expected secret)

@Ndpnt
Copy link
Contributor Author

Ndpnt commented Jan 14, 2026

And here is for a merge commit on main that has no corresponding PR on github https://github.com/Ndpnt/engine/actions/runs/20998466796/job/60361541877

@Ndpnt Ndpnt force-pushed the improve-release-workflow branch from 0dced07 to 199f665 Compare January 14, 2026 15:03
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in sync 🚀

@Ndpnt Ndpnt merged commit bf6c99c into main Jan 14, 2026
14 checks passed
@Ndpnt Ndpnt deleted the improve-release-workflow branch January 14, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants