Improved functionality of the -f option #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
approved these changes
Jun 26, 2025
swryan
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of waiting for all tests to complete in order to generate the failtests.in file, testflo now appends to that file after each failed test, so if there's an MPI hang or something that prevents completion of the testflo run, at least you'll have the names of any tests that failed prior to the hang. Also, if the failed test is an MPI test (assuming it fails normally and doesn't hang) then a comment will be added after that line in the failtests.in file that says it's an mpi test and lists the number of procs.
Also, testflo now sets an environment variable called 'TESTFLO_SPEC' when running each test that contains the test specification string for that test. An update to OpenMDAO will use that information to allow om_dump to send its output to a file named after the test spec.
New Dependencies
None