Add config option to include drop fixes #313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.ini
Outdated
|
|
||
| # should drop fixes be enabled? | ||
| # this includes changes that fix stuff like Fusionfly and Freakosaurus Rex drops | ||
| # and also fix Academy-specific mobs with no drops |
Member
There was a problem hiding this comment.
I would re-word this to clarify what exactly "fix" means. Something like: "This adds drops to mobs that previously didn't have any or drops that weren't in the drop table. This is polish that is slightly inauthentic to the original game."
Contributor
Author
There was a problem hiding this comment.
Much clearer, thanks!
src/settings.cpp
Outdated
| if (ENABLEDPATCHES.empty()) { | ||
| ENABLEDPATCHES = "0104-fix"; | ||
| } else { | ||
| ENABLEDPATCHES += " 0104-fix 1013-fix"; |
Member
There was a problem hiding this comment.
nit: I would rename these to 0104-fixes to make it extra clear that this is a plurality of miscellaneous adjustments; especially if we keep adding to these patches in the future.
Contributor
Author
There was a problem hiding this comment.
Done, makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OpenFusionProject/tabledata#24 PR, we've refactored certain convenient drop fixes to their own patches. This PR is to allow these patches to be included easier with
config.inioptions.