This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Yes, we can delete patch as update does already the job#53
Open
Yes, we can delete patch as update does already the job#53
Conversation
taylordowns2000
suggested changes
Dec 24, 2021
Member
taylordowns2000
left a comment
There was a problem hiding this comment.
I'm still seeing this in the DHIS2 web api docs: https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-235/web-api.html#webapi_partial_updates
I know it's possible that those docs are out of date, but it still seems strange that they make sure a big point of "partial updates".
Also, if we delete this I wonder if it's worth giving an example of changing the the http request method in update to use patch instead of put. Something like:
update(resourceType, path, data, {
requestConfig: { method: 'PATCH' }
})Also, it looks like the changes to ast.json are unintentional here. I bet you need to run npm install to get the latest version of simple-ast, but please take care to keep unintentional changes out of PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DHIS2 it's very possible to update a resource by just sending the parts we wanna update. Expression's like this:
work very well.