[BUG FIX] AeroAcoustics module angle range #3134
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if using `TICalcMeth = 2`, the angle calculated is in the range [-180,180] degrees, but the logic lower in the UpdateStates routine assumes the angle is in the range [0, 360] degrees
bjonkman
commented
Jan 8, 2026
ptrbortolotti
approved these changes
Jan 8, 2026
Contributor
ptrbortolotti
left a comment
ptrbortolotti
left a comment
There was a problem hiding this comment.
I've never truly used TICalcMeth = 2, thanks for debugging this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
If using
TICalcMeth = 2, the angle calculated is in the range [-180,180] degrees, but the logic lower in the UpdateStates routine assumes the angle is in the range [0, 360] degrees.Impacted areas of the software
AeroAcoustics module
Test results, if applicable
The regression tests for aeroacoustics uses
TICalcMeth = 1, so this will not affect any current tests.