[Bug Fix] Fix the element size calculation in AeroAcoustics module #3133
Conversation
On last node, the element size was calculated as half the distance in span between the last two nodes. This should not be divided by 2.
|
This has a relatively large impact on the measurements for |
| tempmean=SUM(xd%RegVxStor(:,k_minus1,rco_minus1)) | ||
| tempmean=tempmean/size(xd%RegVxStor,1) | ||
| xd%RegionTIDelete(k_minus1,rco_minus1)=SQRT((SUM((xd%RegVxStor(:,k_minus1,rco_minus1)-tempmean)**2)) / size(xd%RegVxStor,1) ) | ||
| xd%TIVx(j,i) = xd%RegionTIDelete(k_minus1,rco_minus1) ! only the fluctuation |
There was a problem hiding this comment.
Another question for @ptrbortolotti:
when TICalcMethod = 2, it computes this TIVx in line 673 as the standard deviation of the Inflow vector (in each bin). This is NOT the TI. Should we be dividing this xd%TIVx(j,i) by tempmean to get TI here?
It gets used in the InflowNoise() calculation, where it assumes it's TI.
There was a problem hiding this comment.
another good catch @bjonkman. frankly I've never used TICalcMethod =2. back at TUM we saw that the method, even when implemented correctly, took a long time to converge and we always relied on user-defined input TI
|
3 participants
Feature or improvement description
On last node (at the tip), the element size for aeroacoustics calculations was calculated as half the difference in span locations between the last two nodes. This should not be divided by 2.
Related issue, if one exists
Impacted areas of the software
AeroAcoustics only
Test results, if applicable
The AeroAcoustics regression test,
IEA_LB_RWT-AeroAcousticsfails. Here are some of the failing channels: