add --venv_path option for running without containers#37
Open
timurcarstensen wants to merge 101 commits intomainfrom
Open
add --venv_path option for running without containers#37timurcarstensen wants to merge 101 commits intomainfrom
timurcarstensen wants to merge 101 commits intomainfrom
Conversation
Add a GitHub Actions workflow that sets up a real SLURM cluster with Apptainer on a GPU runner to test the schedule_evals workflow end-to-end. - New workflow: slurm-integration.yml - Sets up SLURM (slurmctld + slurmd) on AWS GPU runner - Installs Apptainer and builds test container - Pre-downloads tiny-gpt2 model and arc_easy dataset - Runs integration test that validates full workflow - New test container: tests/integration/ci.def - Based on PyTorch with CUDA support - Includes lm_eval and dependencies - New integration test: tests/integration/test_slurm.py - Submits real SLURM job via schedule_evals - Waits for completion and validates results JSON - Updated clusters.yaml with CI cluster configuration
Switch to CPU instances (i7ie) since GPU quota is not available: - Remove GPU/GRES configuration from SLURM setup - Update test to support --dry-run mode for CPU-only testing - Validate sbatch script generation without actual job execution - Update CI cluster config to use debug partition Full GPU testing can be re-enabled later when quota is available.
geoalgo
reviewed
Feb 5, 2026
Collaborator
geoalgo
left a comment
There was a problem hiding this comment.
Could we make this PR independent of the AWS integration?
The line diffs are: +1 077-153 whereas it seems like it should be just be about two files that are changed?
Collaborator
Author
I was going to merge this after merging #28 so it would show up as only 2 files being changed after merging main into this feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--venv_pathtoschedule-eval. If provided, jobs run using that venv instead of a container.CI updated to test both modes.
merge after #28
Summary: