Adds interval to verb refresh, and uses OnButtonDown for verb panel buttons #2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2484 I've had issues clicking on verbs in TestGame and Goonstation, where clicking on a verb would often act like it was not clicked, unless I did a very fast single click. It seems to be because the verbs are refreshed in the short time between pushing my mouse button down and releasing it, and so the mouse up and down are not happening on the same control, which makes it not an OnPressed event.
Also, the rapid refreshing causes the verb button text to flash while the mouse cursor is over it.
This PR just makes verb panel buttons act on the OnButtonDown event to deal with the event dropping, and adds an interval to the refreshing to reduce the flashing. The OnButtonDown change also happens to be parity with Byond.