Skip to content

Conversation

@cyrillkuettel
Copy link
Contributor

@cyrillkuettel cyrillkuettel commented Dec 23, 2025

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Adds explicit last_login on User

TYPE: Feature
LINK: OGC-2454

Checklist

  • I have performed a self-review of my code

@linear
Copy link

linear bot commented Dec 23, 2025

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (9581090) to head (be1d0ac).
⚠️ Report is 23 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/user/auth/core.py 92.09% <100.00%> (+0.04%) ⬆️
src/onegov/user/models/user.py 98.49% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9581090...be1d0ac. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyrillkuettel cyrillkuettel force-pushed the ogc-2454-eigenes-feld-fur-last-login-auf-user branch from 13fec7a to 2280603 Compare December 23, 2025 18:02
Copy link
Member

@Daverball Daverball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We may be able to do a little bit better with the migration, by pre-populating the new column using any stored session timestamps, if you'd like to try. (users.data['sessions'][...]['timestamp'])

@cyrillkuettel cyrillkuettel merged commit 790bad6 into master Jan 8, 2026
16 checks passed
@cyrillkuettel cyrillkuettel deleted the ogc-2454-eigenes-feld-fur-last-login-auf-user branch January 8, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants