Add ArbFilteredTransactionsManager precompile #4174
+616
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2025
MishkaRogachev
changed the title
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
from
1adc79f to
81f4e5e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4174 +/- ##
==========================================
- Coverage 33.41% 32.93% -0.49%
==========================================
Files 461 463 +2
Lines 55901 56029 +128
==========================================
- Hits 18681 18453 -228
- Misses 33921 34360 +439
+ Partials 3299 3216 -83 |
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
2 times, most recently
from
45fb413 to
67c13f2
Compare
MishkaRogachev
changed the title
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
2 times, most recently
from
acf9398 to
7b7a735
Compare
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
from
7b7a735 to
f56f36c
Compare
MishkaRogachev
requested review from
Tristan-Wilson,
diegoximenes and
tsahee
Tristan-Wilson
requested changes
Dec 29, 2025
Member
Tristan-Wilson
left a comment
Tristan-Wilson
left a comment
There was a problem hiding this comment.
Looks good, just a minor comment about consistency of the interface with other precompiles.
| return filteredState.IsFiltered(txHash) | ||
| } | ||
|
|
||
| func (con ArbFilteredTransactionsManager) hasAccess(c *Context) (bool, error) { |
Member
There was a problem hiding this comment.
This signature is slightly different to ArbNativeTokenManager which has
func (con ArbNativeTokenManager) hasAccess(c ctx) bool {
manager, err := c.State.NativeTokenOwners().IsMember(c.caller)
return manager && err == nil
}
and therefore the behavior when there is an error is slightly different in this implementation in that if there is an error, then the gas is not burned out.
Unsure if this difference is intentional or not.
Member
|
We should consider making |
Contributor
Author
@Tristan-Wilson, wdyt about going further: remove ArbNativeToken-style check and return an error right in CensorPrecompile, like in ArbOwner? |
| "github.com/offchainlabs/nitro/solgen/go/precompilesgen" | ||
| ) | ||
|
|
||
| func TestManageTransactionCensors(t *testing.T) { |
Member
There was a problem hiding this comment.
Can you please also test that the transactions that should be free are free? You can look at TestArbNativeTokenManager and getGasUsed inside it for inspiration.
Contributor
Author
There was a problem hiding this comment.
I don't really get how to use getGasUsed in this case, since the transaction will still cost something, only the add/delete call is free. I can suggest to use multigas like this:
tx, err = arbFilteredTxs.AddFilteredTransaction(&censorTxOpts, txHash)
require.NoError(t, err)
receipt, err := builder.L2.EnsureTxSucceeded(tx)
require.NoError(t, err)
require.Equal(t, uint64(0), receipt.MultiGasUsed.Get(multigas.ResourceKindStorageAccess))
This somehow proves that tx did not perform any storage operations like set and clear
Member
There was a problem hiding this comment.
Could you check the censor account's balance is unchanged after adding/deleting filtered txs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NIT-4152
pulls in OffchainLabs/nitro-precompile-interfaces#25
pulls in OffchainLabs/go-ethereum#604
pulls in OffchainLabs/nitro-testnode#169
Changes:
ArbFilteredTransactionsManagerto manage filtered transactionsArbFilteredTransactionsManager